lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] m68k: use read_persistent_clock64 consistently
    On Mon, Apr 23, 2018 at 10:52 AM, Arnd Bergmann <arnd@arndb.de> wrote:
    > We have two ways of getting the current time from a platform at boot
    > or during suspend: either using read_persistent_clock() or the rtc
    > class operation. We never need both, so I'm hiding the
    > read_persistent_clock variant when the generic RTC is enabled.
    >
    > Since read_persistent_clock() and mktime() are deprecated because of
    > the y2038 overflow of time_t, we should use the time64_t based
    > replacements here.
    >
    > Finally, the dependency on CONFIG_ARCH_USES_GETTIMEOFFSET looks
    > completely bogus in this case, so let's remove that. It was
    > added in commit b13b3f51ff7b ("m68k: fix inclusion of
    > arch_gettimeoffset for non-MMU 68k classic CPU types") to deal
    > with arch_gettimeoffset(), which has since been removed from
    > this file and is unrelated to the RTC functions.
    >
    > The rtc accessors are only used by classic machines, while
    > coldfire uses proper RTC drivers, so we can put the old
    > ifdef back around both functions.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    Thanks, applied and queued for v4.18 with Baolin's Rb.

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2018-04-24 12:25    [W:4.184 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site