lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] do not call trace_printk on non-debug build
On Tue, 24 Apr 2018 11:08:10 -0700
Wei Wang <wvw@google.com> wrote:

> From: Wei Wang <wvw@google.com>
>
> trace_printk will cause trace_printk_init_buffers executed in kernel
> start, which will increase memory and also show bad warnings in
> production kernel.
>

NAK!

Where is trace_printk() being used to trigger this?

trace_printk() is to be added while debugging, but one should not need
to enable DEBUG to use it. But it should be removed when finished.

-- Steve

> Signed-off-by: Wei Wang <wvw@google.com>

\
 
 \ /
  Last update: 2018-04-24 20:51    [W:0.085 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site