lkml.org 
[lkml]   [2018]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Experiencing freezes with kernel 4.16.3 on a desktop with E5500 CPU (bisect included)
    On Mon, Apr 23, 2018 at 02:38:47PM +0200, Peter Zijlstra wrote:

    > @@ -142,6 +152,13 @@ static void __clocksource_unstable(struct clocksource *cs)
    > cs->flags &= ~(CLOCK_SOURCE_VALID_FOR_HRES | CLOCK_SOURCE_WATCHDOG);
    > cs->flags |= CLOCK_SOURCE_UNSTABLE;
    >
    > + if (list_empty(&cs->list)) {
    > + cs->rating = 0;
    > + return;
    > + }
    > +
    > + __clocksource_change_rating(cs, 0);
    > +
    > if (cs->mark_unstable)
    > cs->mark_unstable(cs);
    >

    Thomas, we could not find the de-rate stuff, but the above can be
    simplified; what happens is:

    cs->flags |= UNSTABLE;
    schedule_work(&watchdog_work)
    kthread_run(clocksource_watchdog_kthread)
    __clocksource_watchdog_kthread()
    if (cs->flags & UNSTABLE)
    __clocksource_change_rating()
    clocksource_select()

    \
     
     \ /
      Last update: 2018-04-23 17:58    [W:2.568 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site