Messages in this thread | | | Date | Mon, 23 Apr 2018 08:09:23 +0200 | From | Ahmed Abdelsalam <> | Subject | Re: [PATCH] [net] ipv6: sr: fix NULL pointer dereference in seg6_do_srh_encap()- v4 pkts |
| |
On Sun, 22 Apr 2018 21:06:04 -0400 (EDT) David Miller <davem@davemloft.net> wrote:
> From: Ahmed Abdelsalam <amsalam20@gmail.com> > Date: Fri, 20 Apr 2018 15:58:05 +0200 > > > In case of seg6 in encap mode, seg6_do_srh_encap() calls set_tun_src() > > in order to set the src addr of outer IPv6 header. > > > > The net_device is required for set_tun_src(). However calling ip6_dst_idev() > > on dst_entry in case of IPv4 traffic results on the following bug. > > > > Using just dst->dev should fix this BUG. > ... > > Fixes: 8936ef7604c11 ipv6: sr: fix NULL pointer dereference when setting encap source address > > Please format your Fixes: tag properly next time. The commit header > text should be enclosed by (" "). I fixed it up for you this time. >
Ok! Thanks David for your time.
> > Signed-off-by: Ahmed Abdelsalam <amsalam20@gmail.com> > > Applied and queued up for -stable.
-- Ahmed Abdelsalam <amsalam20@gmail.com>
| |