lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 094/196] ext4: always initialize the crc32c checksum driver
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit a45403b51582a87872927a3e0fc0a389c26867f1 upstream.

    The extended attribute code now uses the crc32c checksum for hashing
    purposes, so we should just always always initialize it. We also want
    to prevent NULL pointer dereferences if one of the metadata checksum
    features is enabled after the file sytsem is originally mounted.

    This issue has been assigned CVE-2018-1094.

    https://bugzilla.kernel.org/show_bug.cgi?id=199183
    https://bugzilla.redhat.com/show_bug.cgi?id=1560788

    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/super.c | 15 ++++++---------
    1 file changed, 6 insertions(+), 9 deletions(-)

    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -3490,15 +3490,12 @@ static int ext4_fill_super(struct super_
    }

    /* Load the checksum driver */
    - if (ext4_has_feature_metadata_csum(sb) ||
    - ext4_has_feature_ea_inode(sb)) {
    - sbi->s_chksum_driver = crypto_alloc_shash("crc32c", 0, 0);
    - if (IS_ERR(sbi->s_chksum_driver)) {
    - ext4_msg(sb, KERN_ERR, "Cannot load crc32c driver.");
    - ret = PTR_ERR(sbi->s_chksum_driver);
    - sbi->s_chksum_driver = NULL;
    - goto failed_mount;
    - }
    + sbi->s_chksum_driver = crypto_alloc_shash("crc32c", 0, 0);
    + if (IS_ERR(sbi->s_chksum_driver)) {
    + ext4_msg(sb, KERN_ERR, "Cannot load crc32c driver.");
    + ret = PTR_ERR(sbi->s_chksum_driver);
    + sbi->s_chksum_driver = NULL;
    + goto failed_mount;
    }

    /* Check superblock checksum */

    \
     
     \ /
      Last update: 2018-04-22 18:01    [W:4.578 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site