lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 073/164] ext4: eliminate sleep from shutdown ioctl
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit a6d9946bb925293fda9f5ed6d33d8580b001f006 upstream.

    The msleep() when processing EXT4_GOING_FLAGS_NOLOGFLUSH was a hack to
    avoid some races (that are now fixed), but in fact it introduced its
    own race.

    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/ioctl.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/fs/ext4/ioctl.c
    +++ b/fs/ext4/ioctl.c
    @@ -498,10 +498,8 @@ static int ext4_shutdown(struct super_bl
    break;
    case EXT4_GOING_FLAGS_NOLOGFLUSH:
    set_bit(EXT4_FLAGS_SHUTDOWN, &sbi->s_ext4_flags);
    - if (sbi->s_journal && !is_journal_aborted(sbi->s_journal)) {
    - msleep(100);
    + if (sbi->s_journal && !is_journal_aborted(sbi->s_journal))
    jbd2_journal_abort(sbi->s_journal, 0);
    - }
    break;
    default:
    return -EINVAL;

    \
     
     \ /
      Last update: 2018-04-22 17:20    [W:4.727 / U:0.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site