lkml.org 
[lkml]   [2018]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 22/22] parisc: use generic dma_noncoherent_ops
    From
    Date
    On Fri, 2018-04-20 at 10:03 +0200, Christoph Hellwig wrote:
    > diff --git a/arch/parisc/kernel/setup.c b/arch/parisc/kernel/setup.c
    > index 8d3a7b80ac42..4e87c35c22b7 100644
    > --- a/arch/parisc/kernel/setup.c
    > +++ b/arch/parisc/kernel/setup.c
    > @@ -97,14 +97,12 @@ void __init dma_ops_init(void)
    >   panic( "PA-RISC Linux currently only supports
    > machines that conform to\n"
    >   "the PA-RISC 1.1 or 2.0 architecture
    > specification.\n");
    >  
    > - case pcxs:
    > - case pcxt:
    > - hppa_dma_ops = &pcx_dma_ops;
    > - break;
    >   case pcxl2:
    >   pa7300lc_init();
    >   case pcxl: /* falls through */
    > - hppa_dma_ops = &pcxl_dma_ops;
    > + case pcxs:
    > + case pcxt:
    > + hppa_dma_ops = &dma_noncoherent_ops;
    >   break;
    >   default:
    >   break;

    Well, this is wrong: you just made every 32 bit parisc system
    unnecessarily use non-coherent. We actually only have a small small
    set of non-coherent systems. The pxcs and pcxt systems (which are
    about 99% of the user base) can use coherent dma ops. The problem
    seems to be in your new world you only have one dma_noncoherent_ops
    pointer ... we definitely need two on parisc, so whether
    arch_dma_cache_sync is present or not needs to be dynamic not config
    defined.

    James

    \
     
     \ /
      Last update: 2018-04-21 23:44    [W:5.044 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site