lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 49/61] staging: nvec: simplify getting .drvdata
    Date
    Am Donnerstag, 19. April 2018, 16:06:19 CEST schrieb Wolfram Sang:
    > We should get drvdata from struct device directly. Going via
    > platform_device is an unneeded step back and forth.
    >
    > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

    Acked-by: Marc Dietrich <marvin24@gmx.de>

    > ---
    >
    > Build tested only. buildbot is happy. Please apply individually.
    >
    > drivers/staging/nvec/nvec.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
    > index 52054a528723..2a5e0dcf4162 100644
    > --- a/drivers/staging/nvec/nvec.c
    > +++ b/drivers/staging/nvec/nvec.c
    > @@ -925,8 +925,7 @@ static int tegra_nvec_remove(struct platform_device
    > *pdev) static int nvec_suspend(struct device *dev)
    > {
    > int err;
    > - struct platform_device *pdev = to_platform_device(dev);
    > - struct nvec_chip *nvec = platform_get_drvdata(pdev);
    > + struct nvec_chip *nvec = dev_get_drvdata(dev);
    > struct nvec_msg *msg;
    > char ap_suspend[] = { NVEC_SLEEP, AP_SUSPEND };
    >
    > @@ -946,8 +945,7 @@ static int nvec_suspend(struct device *dev)
    >
    > static int nvec_resume(struct device *dev)
    > {
    > - struct platform_device *pdev = to_platform_device(dev);
    > - struct nvec_chip *nvec = platform_get_drvdata(pdev);
    > + struct nvec_chip *nvec = dev_get_drvdata(dev);
    >
    > dev_dbg(nvec->dev, "resuming\n");
    > tegra_init_i2c_slave(nvec);




    \
     
     \ /
      Last update: 2018-04-20 10:53    [W:5.434 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site