Messages in this thread | | | Date | Thu, 19 Apr 2018 18:40:43 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc |
| |
On Thu, Apr 19, 2018 at 10:46:15AM -0500, Alex G. wrote: > The bulk of the function is the if/else mapping from UUID to error > handler. I don't see how that can be easily split up, hence why I > originally resorted to the mapping. As you said, we'll keep it simple at > first.
So that function is 43 lines now. Why are we even talking about this?!
Just add your UUID check to the if-else statement and be done with it already. No handlers no nothing.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |