lkml.org 
[lkml]   [2018]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH v2 3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal.
    From
    Date
    Hi Alex,

    (I haven't read through all this yet, just on this one:)

    On 04/19/2018 03:57 PM, Alex G. wrote:
    > Maybe it's better move the AER handling to NMI/IRQ context, since
    > ghes_handle_aer() is only scheduling the real AER andler, and is irq
    > safe. I'm scratching my head about why we're messing with IRQ work from
    > NMI context, instead of just scheduling a regular handler to take care
    > of things.

    We can't touch schedule_work_on() from NMI context as it takes spinlocks and
    disables interrupts. (see __queue_work()) The NMI may have interrupted
    IRQ-context code
    that was already holding the same locks.

    IRQ-work behaves differently, it uses an llist for the work and an arch
    code hook
    to raise a self-IPI.


    Thanks,

    James

    \
     
     \ /
      Last update: 2018-04-19 17:36    [W:3.136 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site