lkml.org 
[lkml]   [2018]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] memory: aemif: add support for board files
2018-04-19 14:09 GMT+02:00 Sekhar Nori <nsekhar@ti.com>:
> On Wednesday 18 April 2018 09:05 PM, Bartosz Golaszewski wrote:
>> @@ -373,15 +372,23 @@ static int aemif_probe(struct platform_device *pdev)
>> goto error;
>> }
>>
>> - /*
>> - * For every controller device node, there is a cs device node that
>> - * describe the bus configuration parameters. This functions iterate
>> - * over these nodes and update the cs data array.
>> - */
>> - for_each_available_child_of_node(np, child_np) {
>> - ret = of_aemif_parse_abus_config(pdev, child_np);
>> - if (ret < 0)
>> - goto error;
>> + if (np) {
>> + /*
>> + * For every controller device node, there is a cs device node
>> + * that describe the bus configuration parameters. This
>> + * functions iterate over these nodes and update the cs data
>> + * array.
>> + */
>> + for_each_available_child_of_node(np, child_np) {
>> + ret = of_aemif_parse_abus_config(pdev, child_np);
>> + if (ret < 0)
>> + goto error;
>> + }
>> + } else if (pdata && pdata->num_abus_data > 0) {
>> + for (i = 0; i < pdata->num_abus_data; i++, aemif->num_cs++) {
>> + aemif->cs_data[i].cs = pdata->abus_data->cs;
>
> Since abus_data is an array, shouldn't it be pdata->abus_data[i].cs ?
>
> Thanks,
> Sekhar

Yes, it should. It only worked because we're using a single config
entry. Thanks, I'll fix it.

Bart

\
 
 \ /
  Last update: 2018-04-19 14:58    [W:0.048 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site