lkml.org 
[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [v5,05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi
Date
On Freitag, 23. März 2018 15:48:48 CEST Sricharan R wrote:
> Add the common parts for the dk04 boards.
>
> Reviewed-by: Abhishek Sahu <absahu@codeaurora.org>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> ---
> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 115 ++++++++++++++++++++++++++
> arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +-
> 2 files changed, 116 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi

The no-map reserved-memory for tz and smem are missing. Linux doesn't have
control over these regions and they are placed in the middle of the ram before
Linux even starts. And u-boot is also not adding these ranges automatically.

reserved-memory {
#address-cells = <0x1>;
#size-cells = <0x1>;
ranges;

smem@87e00000 {
reg = <0x87e00000 0x080000>;
no-map;
};

tz@87e80000 {
reg = <0x87e80000 0x180000>;
no-map;
};
};

This can either (depending on HW/SW configuration) lead to a failed boot [1]
or to runtime crashes like:

root@OpenWrt:/# /tmp/memory-allocator-test
main 0
[ 571.758058] Unhandled fault: imprecise external abort (0xc06) at 0x01715ff8
[ 571.758099] pgd = cebec000
[ 571.763826] [01715ff8] *pgd=8e7fa835, *pte=87e7f75f, *ppte=87e7fc7f
Bus error

I would not know how to disable QSEE on these boards and thus would assume
that it should be part of this dtsi.

Kind regards,
Sven

[1] https://www.spinics.net/lists/linux-arm-msm/msg21536.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-04-18 09:00    [W:0.635 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site