Messages in this thread | | | Subject | Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU | From | Robin Murphy <> | Date | Tue, 17 Apr 2018 18:55:49 +0100 |
| |
On 17/04/18 18:36, Hook, Gary wrote: > On 4/13/2018 7:55 PM, Mehta, Sohil wrote: >> On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: >>> +struct dentry *iommu_debugfs_setup(void) >>> +{ >>> + if (!debugfs_initialized()) >> >> This check is probably not needed. > > Ah, so it isn't. Thank you. > >> >>> + return NULL; >>> + >>> + if (!iommu_debugfs_dir) >>> + iommu_debugfs_dir = debugfs_create_dir("iommu", >>> NULL); >>> + >>> + if (iommu_debugfs_dir) >>> + pr_warn("WARNING: IOMMU DEBUGFS SUPPORT HAS BEEN >>> ENABLED IN THIS KERNEL\n"); >>> + >> >> As this gets called for each IOMMU, do you want to use pr_warn_once? > > That works, yes.
Or I guess you could just roll the pr_warn() into the previous if() condition, i.e. only warn when the singleton debugfs_dir is actually created.
Robin.
> >> >>> + return iommu_debugfs_dir; >>> +} >>> +EXPORT_SYMBOL_GPL(iommu_debugfs_setup); >> >> -Sohil >> > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu
| |