lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI trace events
Date
Hi, Bart

>mingo@redhad.com; linux-block@vger.kernel.org; rajatja@google.com
>Subject: [EXT] Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI
>trace events
>
>On Mon, 2018-04-16 at 14:31 +0000, Bean Huo (beanhuo) wrote:
>> TP_printk("host_no=%u channel=%u id=%u lun=%u data_sgl=%u
>prot_sgl=%u" \
>> - " prot_op=%s cmnd=(%s %s raw=%s)",
>> + " prot_op=%s tag=%d cmnd=(%s %s raw=%s)",
>>
>> [ ... ]
>> TP_printk("host_no=%u channel=%u id=%u lun=%u data_sgl=%u
>prot_sgl=%u" \
>> - " prot_op=%s cmnd=(%s %s raw=%s) rtn=%d",
>> + " prot_op=%s tag=%d cmnd=(%s %s raw=%s) rtn=%d",
>> [ ... ]
>> TP_printk("host_no=%u channel=%u id=%u lun=%u data_sgl=%u " \
>> - "prot_sgl=%u prot_op=%s cmnd=(%s %s raw=%s)
>result=(driver=" \
>> - "%s host=%s message=%s status=%s)",
>> + "prot_sgl=%u prot_op=%s tag=%d cmnd=(%s %s raw=%s) " \
>> + "result=(driver=%s host=%s message=%s status=%s)",
>
>Which tools process these strings? Has it been verified whether or not the
>tools that process these strings still work fine with this patch applied?
>

I don't use one certain special tool to analyze this string, I am using ftrace with event.
With tag information, I can see how many tasks in storage device and easily to trace each request
under multiple thread workload.
Event there is someone who using certain tool to analyze this string, after adding additional
tag printout, in my opinion, they are happy to see it there.

Again, you said if we add new feature in legacy block, we will also add new feature in blk-mq.
I still don't understand here. "include/trace/event/block.h ... scsi.h" will be changed?
If yes, how? Because blk-mq is still using the events defined in include/trace/event/block.h.

Bean Huo

>Thanks,
>
>Bart.
>

\
 
 \ /
  Last update: 2018-04-16 23:14    [W:0.034 / U:0.632 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site