lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] isofs: fix potential memory leak in mount option parsing
On Sat 14-04-18 20:16:06, Chengguang Xu wrote:
> When specifying string type mount option (e.g., iocharset)
> several times in a mount, current option parsing may
> cause memory leak. Hence, call kfree for previous one
> in this case. Meanwhile, check memory allocation result
> for it.
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>

Thanks. I've added the patch to my tree.

Honza

> ---
> fs/isofs/inode.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index bc258a4..ec3fba7 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -394,7 +394,10 @@ static int parse_options(char *options, struct iso9660_options *popt)
> break;
> #ifdef CONFIG_JOLIET
> case Opt_iocharset:
> + kfree(popt->iocharset);
> popt->iocharset = match_strdup(&args[0]);
> + if (!popt->iocharset)
> + return 0;
> break;
> #endif
> case Opt_map_a:
> --
> 1.8.3.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2018-04-16 09:49    [W:0.033 / U:2.964 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site