lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] trace: add missing forward declaration
It does not fail with any config without this fix. This is for new work.

-- Ahbong

On Mon, Apr 16, 2018 at 9:24 PM Steven Rostedt <rostedt@goodmis.org> wrote:

> On Mon, 16 Apr 2018 10:36:25 +0800
> Ahbong Chang <cwahbong@google.com> wrote:

> > Without this forward declaration compile may fail if this header is
> > included only for registering other probe event without struct
> > pool_workqueue.
> >

> Is this for new work or is there a config which this fails with today?

> -- Steve

> > Signed-off-by: Ahbong Chang <cwahbong@google.com>
> > Reviewed-by: Todd Poynor <toddpoynor@google.com>
> > ---
> > include/trace/events/workqueue.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/trace/events/workqueue.h
b/include/trace/events/workqueue.h
> > index 2f057a494d93..9a761bc6a251 100644
> > --- a/include/trace/events/workqueue.h
> > +++ b/include/trace/events/workqueue.h
> > @@ -25,6 +25,8 @@ DECLARE_EVENT_CLASS(workqueue_work,
> > TP_printk("work struct %p", __entry->work)
> > );
> >
> > +struct pool_workqueue;
> > +
> > /**
> > * workqueue_queue_work - called when a work gets queued
> > * @req_cpu: the requested cpu

\
 
 \ /
  Last update: 2018-04-17 04:19    [W:0.072 / U:1.760 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site