lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
    On Sun, Apr 15, 2018 at 5:06 AM Christoph Hellwig <hch@infradead.org> wrote:

    > On Fri, Apr 13, 2018 at 12:06:44AM -0700, Greg Thelen wrote:
    > > Allow INFINIBAND without INFINIBAND_ADDR_TRANS.

    > Why? We are pushing everyone heavily to use RDMA/CM, so making it
    > optional seems rather counter-intuitive.

    Bugs. We don't currently use CM. But fuzzy testing has been finding a
    fair number CM bugs, so we were thinking of disabling it until we need it.

    > You'll also have to fix tons of ULPs to explicitly depend on
    > INFINIBAND_ADDR_TRANS, or make code conditional on it.

    I think I've identified the set of options which use
    INFINIBAND_ADDR_TRANS without a kconfig depends:
    * CIFS_SMB_DIRECT
    * INFINIBAND_SRPT
    * NVME_RDMA
    * NVME_TARGET_RDMA

    I have patches for the above, but need to finish the commit logs. Let me
    know if they'll be nacked and I'll just patch my kernel and forget
    upstreaming.

    \
     
     \ /
      Last update: 2018-04-16 06:03    [W:2.130 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site