Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [GIT PULL] Thermal management updates for v4.17-rc1 | Date | Fri, 13 Apr 2018 12:27:17 +0200 |
| |
On Friday, April 13, 2018 03:08:03 AM Eduardo Valentin wrote: > On Fri, Apr 13, 2018 at 01:39:05PM +0800, Zhang Rui wrote: > > Hi, Eduardo, > > > > On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > > > Hello, > > > > > > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: > > > > > > > > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui <rui.zhang@intel.com> > > > > wrote: > > > > > > > > > > > > > > > could you please illustrate me what the kconfig & warning is? > > > > Just "make allmodconfig" and the warning is about a uninitialized > > > > variable. > > > > > > > > Line 304 in drivers/thermal/samsung/exynos_tmu.c if my shell > > > > history > > > > is to be believed. > > > > > > > > Linus > > > Yeah, this has also passed my local compilation error. Somehow my > > > gcc4.9 > > > is not catching it. Using an older gcc (gcc4.6) does catch it. > > > > > > Anyways, given that the conversion functions are written to cover > > > for unexpected cal_type, the right way of fixing this is to rewrite > > > the conversion functions to allow for returning error codes and > > > adjusting the callers as expected. > > > > > > Rui, bzolnier, please consider the following fix: > > > > > as it is late in this merge window, I'd prefer to > > 1. drop all the thermal-soc material in the first pull request which I > > will send out soon. > > 2. you can prepare another pull request containing the thermal-soc > > materials except the exynos fixes > > 3. exynos fixes with the problem solved can be queued for -rc2 or > > later. > > > > Agreed
What should I do now to help resolve the issue?
[ There has been no action from you on Arnd's fix for over two weeks and also you have not commented on it now.. ]
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |