lkml.org 
[lkml]   [2018]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH 01/35] vfs: clean up dedup
    On Thu, Apr 12, 2018 at 6:25 PM, Matthew Wilcox <willy@infradead.org> wrote:
    > On Thu, Apr 12, 2018 at 05:07:52PM +0200, Miklos Szeredi wrote:
    >> +ssize_t vfs_dedupe_file_range_one(struct file *src_file, u64 src_pos, u64 len,
    >> + struct file *dst_file, u64 dst_pos)
    >
    > Why u64 instead of loff_t?

    Peculiarity of f_op->dedupe_file_range().

    I think a cleanup of copyfile/clone/dedupe interfaces would be good.
    Perhaps merge them into one? Or just merge copyfile/clone? Even if
    not merging it should make sense to make argument types and argument
    order the same.

    Thanks,
    Miklos

    \
     
     \ /
      Last update: 2018-04-12 19:24    [W:2.917 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site