Messages in this thread | | | Subject | Re: [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page | From | Paolo Bonzini <> | Date | Thu, 12 Apr 2018 16:38:39 +0200 |
| |
On 21/02/2018 18:47, KarimAllah Ahmed wrote: > + > + if (kvm_vcpu_map(vcpu, gpa_to_gfn(vmcs12->virtual_apic_page_addr), map)) > + vmcs_write64(VIRTUAL_APIC_PAGE_ADDR, gfn_to_gpa(map->pfn));
This should in principle be pfn_to_hpa. However, pfn_to_hpa is unused; let's just remove it and do "<< PAGE_SHIFT". Unlike gfn_to_gpa, where in principle the shift could be different, pfn_to_hpa is *by definition* a shift left by PAGE_SHIFT.
Paolo
| |