lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 248/310] cpuidle: dt: Add missing of_node_put()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>


    [ Upstream commit b2cdd8e1b54849477a32d820acc2e87828a38f3d ]

    'of_node_put()' should be called on pointer returned by
    'of_parse_phandle()' when done. In this function this is done in all path
    except this 'continue', so add it.

    Fixes: 97735da074fd (drivers: cpuidle: Add status property to ARM idle states)
    Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/cpuidle/dt_idle_states.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/cpuidle/dt_idle_states.c
    +++ b/drivers/cpuidle/dt_idle_states.c
    @@ -174,8 +174,10 @@ int dt_init_idle_driver(struct cpuidle_d
    if (!state_node)
    break;

    - if (!of_device_is_available(state_node))
    + if (!of_device_is_available(state_node)) {
    + of_node_put(state_node);
    continue;
    + }

    if (!idle_state_valid(state_node, i, cpumask)) {
    pr_warn("%s idle state not valid, bailing out\n",

    \
     
     \ /
      Last update: 2018-04-11 21:22    [W:2.920 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site