lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4] gpio: Remove VLA from gpiolib
On Tue, Apr 10, 2018 at 06:03:52PM -0700, Laura Abbott wrote:
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -61,6 +61,11 @@ static struct bus_type gpio_bus_type = {
> .name = "gpio",
> };
>
> +/*
> + * Number of GPIOs to use for the fast path in set array
> + */
> +#define FASTPATH_NGPIO 256

Hm, this has regressed from 384 back to 256 since v3.


> @@ -2653,6 +2661,7 @@ static int gpio_chip_get_multiple(struct gpio_chip *chip,
> return -EIO;
> }
>
> +
> int gpiod_get_array_value_complex(bool raw, bool can_sleep,

Spurious newline. (In v3 this was the place where FASTPATH_NGPIO was
defined, this is a leftover from when you moved it further up.)

I've given this another quick test with gpio-hammer and it worked fine,
so this is still
Reviewed-and-tested-by: Lukas Wunner <lukas@wunner.de>

Thanks a lot!

Lukas

\
 
 \ /
  Last update: 2018-04-11 17:03    [W:0.076 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site