Messages in this thread | | | From | Baolin Wang <> | Date | Wed, 11 Apr 2018 18:49:59 +0800 | Subject | Re: [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type |
| |
Hi Vinod,
On 11 April 2018 at 17:24, Vinod Koul <vinod.koul@intel.com> wrote: > On Tue, Apr 10, 2018 at 03:46:03PM +0800, Baolin Wang wrote: >> From: Eric Long <eric.long@spreadtrum.com> >> >> Define the DMA transfer step type to make code more readable. >> >> Signed-off-by: Eric Long <eric.long@spreadtrum.com> >> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> >> --- >> drivers/dma/sprd-dma.c | 28 ++++++++++++++++++++++------ >> 1 file changed, 22 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c >> index b106e8a..af9c156 100644 >> --- a/drivers/dma/sprd-dma.c >> +++ b/drivers/dma/sprd-dma.c >> @@ -169,6 +169,22 @@ enum sprd_dma_int_type { >> SPRD_DMA_CFGERR_INT, >> }; >> >> +/* >> + * enum sprd_dma_step: define the DMA transfer step type >> + * @SPRD_DMA_NONE_STEP: transfer do not need step >> + * @SPRD_DMA_BYTE_STEP: transfer step is one byte >> + * @SPRD_DMA_SHORT_STEP: transfer step is two bytes >> + * @SPRD_DMA_WORD_STEP: transfer step is one word >> + * @SPRD_DMA_DWORD_STEP: transfer step is double word >> + */ >> +enum sprd_dma_step { > > looking at bit defines, does it need to be enum? a #define would just be fine.
Right. It seems more clear if we combined them into one enum structure, but I can convert to #define if you have strong preference. Thanks.
-- Baolin.wang Best Regards
| |