lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.15 025/168] gpiolib: dont dereference a desc before validation
    Date
    4.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vladimir Zapolskiy <vz@mleia.com>


    [ Upstream commit 30322bcf82d74cad0d6e1cf9ba7fa7fa48c7a026 ]

    The fix restores a proper validation of an input gpio desc, which
    might be needed to deal with optional GPIOs correctly.

    Fixes: 02e479808b5d ("gpio: Alter semantics of *raw* operations to actually be raw")
    Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpio/gpiolib.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/gpio/gpiolib.c
    +++ b/drivers/gpio/gpiolib.c
    @@ -2468,7 +2468,7 @@ EXPORT_SYMBOL_GPL(gpiod_direction_output
    */
    int gpiod_direction_output(struct gpio_desc *desc, int value)
    {
    - struct gpio_chip *gc = desc->gdev->chip;
    + struct gpio_chip *gc;
    int ret;

    VALIDATE_DESC(desc);
    @@ -2485,6 +2485,7 @@ int gpiod_direction_output(struct gpio_d
    return -EIO;
    }

    + gc = desc->gdev->chip;
    if (test_bit(FLAG_OPEN_DRAIN, &desc->flags)) {
    /* First see if we can enable open drain in hardware */
    ret = gpio_set_drive_single_ended(gc, gpio_chip_hwgpio(desc),

    \
     
     \ /
      Last update: 2018-04-11 01:39    [W:4.961 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site