lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v29 1/4] mm: support reporting free page blocks
On Tue, Apr 10, 2018 at 01:54:29PM -0700, Andrew Morton wrote:
> On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> >
> > Andrew, were your questions answered? If yes could I bother you for an ack on this?
> >
>
> Still not very happy that readers are told that "this function may
> sleep" when it clearly doesn't do so. If we wish to be able to change
> it to sleep in the future then that should be mentioned. And even put a
> might_sleep() in there, to catch people who didn't read the comments...
>
> Otherwise it looks OK.

Oh, might_sleep with a comment explaining it's for the future sounds
good to me. I queued this - Wei, could you post a patch on top pls?

--
MST

\
 
 \ /
  Last update: 2018-04-11 01:26    [W:0.124 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site