lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.15 097/168] gpio: thunderx: fix error return code in thunderx_gpio_probe()
    Date
    4.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wei Yongjun <weiyongjun1@huawei.com>


    [ Upstream commit 76e28f5ffed82b1e81a86c4eb8d0420515765620 ]

    Fix to return error code -ENOMEM from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: 5a2a30024d8c ("gpio: Add gpio driver support for ThunderX and OCTEON-TX")
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Acked-by: David Daney <david.daney@cavium.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpio/gpio-thunderx.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/gpio/gpio-thunderx.c
    +++ b/drivers/gpio/gpio-thunderx.c
    @@ -553,8 +553,10 @@ static int thunderx_gpio_probe(struct pc
    txgpio->irqd = irq_domain_create_hierarchy(irq_get_irq_data(txgpio->msix_entries[0].vector)->domain,
    0, 0, of_node_to_fwnode(dev->of_node),
    &thunderx_gpio_irqd_ops, txgpio);
    - if (!txgpio->irqd)
    + if (!txgpio->irqd) {
    + err = -ENOMEM;
    goto out;
    + }

    /* Push on irq_data and the domain for each line. */
    for (i = 0; i < ngpio; i++) {

    \
     
     \ /
      Last update: 2018-04-11 01:21    [W:4.075 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site