Messages in this thread | | | From | Tianyu Lan <> | Subject | Re: [PATCH] KVM/X86: Check input sreg values before loading vcpu | Date | Fri, 9 Mar 2018 07:24:13 +0000 |
| |
Hi Radim: Thanks for your review.
On 3/9/2018 12:15 AM, rkrcmar@redhat.com wrote: > 2018-02-27 06:57+0000, Tianyu Lan: >> From: Lan Tianyu <Tianyu.Lan@microsoft.com> >> >> This patch is to check sreg value first and then load vcpu in order >> to avoid redundant loading/putting vcpu. >> >> Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com> >> --- > > Patch "KVM: x86: KVM_CAP_SYNC_REGS" made significant changes to the > sregs setter, so the patch cannot be applied in current form. > > I think that moving the X86_CR4_OSXSAVE check to guest_cpuid_has still > makes sense, but avoiding the vcpu_load/put would produce worse code > elsewhere and avoiding the load/put is not critical as any error is > probably going to be the end for this VM. >
OK. I will update patch. | |