lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
* Kishon Vijay Abraham I <kishon@ti.com> [180308 08:23]:
> On Wednesday 07 March 2018 08:26 PM, Tony Lindgren wrote:
> > +config PHY_MAPPHONE_MDM6600
> > + tristate "Motorola Mapphone MDM6600 modem USB PHY driver"
> > + depends on OF && USB_SUPPORT
> > + select GENERIC_PHY
> > + select USB_PHY
>
> given that OTG is removed, USB_PHY won't be required anymore. Sorry for not
> stating this explicitly before.

Oh OK I did not know that.

> > + ddata->dev = &pdev->dev;
> > + ddata->phy.dev = ddata->dev;
> > + ddata->phy.label = "phy_mdm6600";
> > + ddata->phy.type = USB_PHY_TYPE_USB2;
>
> All of this can be removed since usb_phy is not required.

> > + usb_add_phy_dev(&ddata->phy);
>
> This should also be removed.

OK cool, will remove and post v4 hopefully tonight at some
point.

Regards,

Tony

\
 
 \ /
  Last update: 2018-03-08 17:07    [W:0.052 / U:18.804 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site