Messages in this thread | | | From | Fabio Estevam <> | Date | Thu, 8 Mar 2018 12:07:45 -0300 | Subject | Re: [PATCH] clk: imx25: set correct parents for ssi ipg clocks |
| |
Hi Martin,
On Thu, Mar 8, 2018 at 11:08 AM, Martin Kaiser <martin@kaiser.cx> wrote: > Hi Fabio, > > Thus wrote Fabio Estevam (festevam@gmail.com): > >> I get audio working from SSI1, but I guess this is due to the fact >> that the bootloader enables the SSI clock: > >> I have the following in U-Boot: > >> /* Enable the clocks */ >> DATA 4 0x53f8000c 0x1fffffff >> DATA 4 0x53f80010 0xffffffff >> DATA 4 0x53f80014 0xfdfff > > I'm using the same initial settings. > > Nevertheless, ssi1_ipg_per is disbled after loading the kernel. > > Digging into this a bit more, it turned out that without my patch, > clk_disable_unused() recognizes ssi1_ipg_per as unused and disables it. > > If my patch is applied and ssi1_ipg_per is declared as parent of > ssi1_ipg, clk_disable_unused() will not disable it and fsl_ssi_startup() > will enable both ssi1_ipg_per and ssi1_ipg before playing sound.
I can get audio to work fine without your patch on a mx25pdk.
In the other i.MX clock drivers we have this same pattern:
clks[IMX6SL_CLK_SSI1_IPG] = imx_clk_gate2_shared("ssi1_ipg", "ipg",
It is not clear to me what is the real issue this patch is trying to fix.
Thanks
| |