lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events
Em Thu, Mar 08, 2018 at 08:28:13AM -0500, Agustin Vega-Frias escreveu:
> On 2018-03-08 08:03, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu:
> > > +++ b/tools/perf/util/parse-events.y
> > > @@ -8,6 +8,7 @@
> > >
> > > #define YYDEBUG 1
> > >
> > > +#include <fnmatch.h>
> > > #include <linux/compiler.h>
> > > #include <linux/list.h>
> > > #include <linux/types.h>
> > > @@ -234,6 +235,10 @@ PE_NAME opt_event_config
> > > if (parse_events_add_pmu(_parse_state, list, $1, $2)) {
> > > struct perf_pmu *pmu = NULL;
> > > int ok = 0;
> > > + char *pattern;
> > > +
> > > + if (asprintf(&pattern, "%s*", $1) < 0)
> > > + YYABORT;

> > + if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0)

> > I completely overlook that you were using this and thus needed that
> > extension, duh, thanks for the patience 8-) and for the new patch.

Further trying to remove my brown paper bag: I thought the '?(...)' type
of thing would be something _users_ would pass on the perf tool command
line, not something used by the tool itself, like on the original
patch.... :-)

> NP Arnaldo, thanks for the quick turnaround on these patches :o)
> Just so I know, since these are my first patches on perf tools,
> where are perf tools patches queued once acked?

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core

If they are super urgent, then they will go to a different branch,
perf/urgent, that is targetted for the current merge window, i.e. right
now:

perf/core -> 4.17
perf/urgent -> 4.16

Thanks, and keep the patches flowing!

- Arnaldo

\
 
 \ /
  Last update: 2018-03-08 14:40    [W:0.039 / U:28.056 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site