lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/19] perf tools: Add refcnt into struct mem_info
On Wed, Mar 07, 2018 at 03:56:59PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 07, 2018 at 04:50:06PM +0100, Jiri Olsa escreveu:
> > It's passed along several hists entries in --hierarchy mode,
> > so it's better we keep track of it.
>
> I like this, but you called it...
>
> > +
> > +struct mem_info *mem_info__aloc(void)
> > +{
> > + struct mem_info *mi = zalloc(sizeof(*mi));
> > +
> > + if (mi)
> > + refcount_set(&mi->refcnt, 1);
> > + return mi;
>
> "aloc" with just one 'l', so I have to fix the typo, while at it I'll
> use what is used elsewhere for this operation, i.e.
>
> struct mem_info *mem_info__new(void);

ok, thanks

jirka

\
 
 \ /
  Last update: 2018-03-08 12:00    [W:0.053 / U:1.220 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site