lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] dell-led: Change dell-led.h to dell-common.h
On Thu, 08 Mar 2018 08:12:06 +0100,
Kai-Heng Feng wrote:
>
> This header will be used for more than just led. Change it to a more
> generic name.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Not sure whether dell-common.h is the best name, but I have no time
for bikeshedding.

For the sound change, feel free to take my ack:
Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

> ---
> drivers/platform/x86/dell-laptop.c | 2 +-
> include/linux/{dell-led.h => dell-common.h} | 4 ++--
> sound/pci/hda/dell_wmi_helper.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
> rename include/linux/{dell-led.h => dell-common.h} (61%)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index c52c6723374b..8ba820e6c3d0 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -29,7 +29,7 @@
> #include <linux/mm.h>
> #include <linux/i8042.h>
> #include <linux/debugfs.h>
> -#include <linux/dell-led.h>
> +#include <linux/dell-common.h>
> #include <linux/seq_file.h>
> #include <acpi/video.h>
> #include "dell-rbtn.h"
> diff --git a/include/linux/dell-led.h b/include/linux/dell-common.h
> similarity index 61%
> rename from include/linux/dell-led.h
> rename to include/linux/dell-common.h
> index 92521471517f..37e4b614dd74 100644
> --- a/include/linux/dell-led.h
> +++ b/include/linux/dell-common.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef __DELL_LED_H__
> -#define __DELL_LED_H__
> +#ifndef __DELL_COMMON_H__
> +#define __DELL_COMMON_H__
>
> int dell_micmute_led_set(int on);
>
> diff --git a/sound/pci/hda/dell_wmi_helper.c b/sound/pci/hda/dell_wmi_helper.c
> index 1b48a8c19d28..56050cc3c0ee 100644
> --- a/sound/pci/hda/dell_wmi_helper.c
> +++ b/sound/pci/hda/dell_wmi_helper.c
> @@ -4,7 +4,7 @@
> */
>
> #if IS_ENABLED(CONFIG_DELL_LAPTOP)
> -#include <linux/dell-led.h>
> +#include <linux/dell-common.h>
>
> enum {
> MICMUTE_LED_ON,
> --
> 2.15.1
>
>

\
 
 \ /
  Last update: 2018-03-08 08:24    [W:0.041 / U:0.204 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site