lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 072/190] Fix driver usage of 128B WQEs when WQ_CREATE is V1.
    Date
    From: James Smart <jsmart2021@gmail.com>

    [ Upstream commit 3f247de750b8dd8f50a2c1390e2a1238790a9dff ]

    There are two versions of a structure for queue creation and setup that the
    driver shares with FW. The driver was only treating as version 0.

    Verify WQ_CREATE with 128B WQEs in V0 and V1.

    Code review of another bug showed the driver passing
    128B WQEs and 8 pages in WQ CREATE and V0.
    Code inspection/instrumentation showed that the driver
    uses V0 in WQ_CREATE and if the caller passes queue->entry_size
    128B, the driver sets the hdr_version to V1 so all is good.
    When I tested the V1 WQ_CREATE, the mailbox failed causing
    the driver to unload.

    Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
    Signed-off-by: James Smart <james.smart@broadcom.com>
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/scsi/lpfc/lpfc_sli.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
    index 8f1df76a77b6..0902ed204ba8 100644
    --- a/drivers/scsi/lpfc/lpfc_sli.c
    +++ b/drivers/scsi/lpfc/lpfc_sli.c
    @@ -13696,6 +13696,9 @@ lpfc_wq_create(struct lpfc_hba *phba, struct lpfc_queue *wq,
    case LPFC_Q_CREATE_VERSION_1:
    bf_set(lpfc_mbx_wq_create_wqe_count, &wq_create->u.request_1,
    wq->entry_count);
    + bf_set(lpfc_mbox_hdr_version, &shdr->request,
    + LPFC_Q_CREATE_VERSION_1);
    +
    switch (wq->entry_size) {
    default:
    case 64:
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-08 07:16    [W:4.193 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site