lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 080/190] wan: pc300too: abort path on failure
    Date
    From: Pan Bian <bianpan2016@163.com>

    [ Upstream commit 2a39e7aa8a98f777f0732ca7125b6c9668791760 ]

    In function pc300_pci_init_one(), on the ioremap error path, function
    pc300_pci_remove_one() is called to free the allocated memory. However,
    the path is not terminated, and the freed memory will be used later,
    resulting in use-after-free bugs. This path fixes the bug.

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/net/wan/pc300too.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wan/pc300too.c b/drivers/net/wan/pc300too.c
    index db363856e0b5..2b064998915f 100644
    --- a/drivers/net/wan/pc300too.c
    +++ b/drivers/net/wan/pc300too.c
    @@ -347,6 +347,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
    card->rambase == NULL) {
    pr_err("ioremap() failed\n");
    pc300_pci_remove_one(pdev);
    + return -ENOMEM;
    }

    /* PLX PCI 9050 workaround for local configuration register read bug */
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-08 07:12    [W:3.087 / U:1.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site