lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 079/190] tipc: check return value of nlmsg_new
    Date
    From: Pan Bian <bianpan2016@163.com>

    [ Upstream commit 78302fd405769c9a9379e9adda119d533dce2eed ]

    Function nlmsg_new() will return a NULL pointer if there is no enough
    memory, and its return value should be checked before it is used.
    However, in function tipc_nl_node_get_monitor(), the validation of the
    return value of function nlmsg_new() is missed. This patch fixes the
    bug.

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    net/tipc/node.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/tipc/node.c b/net/tipc/node.c
    index 5b3e1ea37b6d..db8fbc076e1a 100644
    --- a/net/tipc/node.c
    +++ b/net/tipc/node.c
    @@ -2094,6 +2094,8 @@ int tipc_nl_node_get_monitor(struct sk_buff *skb, struct genl_info *info)
    int err;

    msg.skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
    + if (!msg.skb)
    + return -ENOMEM;
    msg.portid = info->snd_portid;
    msg.seq = info->snd_seq;

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-08 07:12    [W:4.185 / U:0.160 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site