lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] usb: musb: Fix external abort in musb_remove
On Thu, Mar 08, 2018 at 07:00:16PM +0100, Merlijn Wajer wrote:
> Hi,
>
> On 08/03/18 17:46, Bin Liu wrote:
>
>
> > No need to flush, the work is already cancelled at this point.
> >
> >> +
> >> musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> >> + musb_platform_exit(musb);
> >
> > This can be move down to out side of holding the spinlock,
> >
> >> spin_unlock_irqrestore(&musb->lock, flags);
> >
> > to here.
>
> Thank you - with I've verified that it works with these changes. I'm
> surprised, because I believe that I had tried this already. I must have
> missed a step in my testing-routine.
>
> I will send a patch shortly.

Thank you for fixing this up.

Regards,
-Bin.

\
 
 \ /
  Last update: 2018-03-08 19:23    [W:0.038 / U:0.260 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site