lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] dt-bindings: Add support for SAW documentation
On Sun, Mar 04, 2018 at 02:31:49PM +0200, Ilia Lin wrote:
> Add support for SAW controlled regulators in 8x96.
> Document it.
>
> Signed-off-by: Ilia Lin <ilialin@codeaurora.org>
> ---
> .../bindings/regulator/qcom,spmi-regulator.txt | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> index 57d2c65..406f2e5 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> @@ -110,6 +110,11 @@ Qualcomm SPMI Regulators
> Definition: Reference to regulator supplying the input pin, as
> described in the data sheet.
>
> +- qcom,saw-reg:
> + Usage: optional
> + Value type: <phandle>
> + Description: Reference to syscon node defining the SAW registers.
> +
>
> The regulator node houses sub-nodes for each regulator within the device. Each
> sub-node is identified using the node's name, with valid values listed for each
> @@ -201,6 +206,17 @@ see regulator.txt - with additional custom properties described below:
> 2 = 0.55 uA
> 3 = 0.75 uA
>
> +- qcom,saw-slave:
> + Usage: optional
> + Value type: <boo>
> + Description: SAW controlled gang slave. Will not be configured.
> +
> +- qcom,saw-leader:
> + Usage: optional
> + Value type: <boo>
> + Description: SAW controlled gang leader. Will be configured as
> + SAW regulator.
> +
> Example:
>
> regulators {
> @@ -221,3 +237,32 @@ Example:
>
> ....
> };
> +
> +Example 2:
> +
> + saw3: syscon@9A10000 {
> + compatible = "syscon";

syscon should not be used alone. It should have a specific compatible
too.

> + reg = <0x9A10000 0x1000>;
> + };
> +
> + ...
> +
> + spm-regulators {
> + compatible = "qcom,pm8994-regulators";
> + qcom,saw-reg = <&saw3>;

Why not just a child of the syscon?

> + s8 {
> + qcom,saw-slave;
> + };
> + s9 {
> + qcom,saw-slave;
> + };
> + s10 {
> + qcom,saw-slave;
> + };
> + pm8994_s11_saw: s11 {
> + qcom,saw-leader;
> + regulator-always-on;
> + regulator-min-microvolt = <900000>;
> + regulator-max-microvolt = <1140000>;
> + };
> + };
> --
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

\
 
 \ /
  Last update: 2018-03-07 21:42    [W:0.106 / U:0.012 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site