lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel/sys_ni: sort cond_syscall() entries

* Dominik Brodowski <linux@dominikbrodowski.net> wrote:

> Shuffle the cond_syscall() entries in kernel/sys_ni.c around so that they
> are kept in the same order as in include/uapi/asm-generic/unistd.h. For
> better structuring, add the same comments as in that file, but keep a few
> additional comments and extend the commentary where it seems useful.
>
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
>
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index b5189762d275..44c65e4d2528 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -17,245 +17,403 @@ asmlinkage long sys_ni_syscall(void)
> return -ENOSYS;
> }
>
> -cond_syscall(sys_quotactl);
> -cond_syscall(sys32_quotactl);
> -cond_syscall(sys_acct);
> +/*
> + * This list is kept in the same order as include/uapi/asm-generic/unistd.h.
> + * Architecture specific entries go below, then follow deprecated or obsolote
> + * system calls.

That's both a typo and wrong: 'follow' in this context means the exact opposite
ordering.

I think this is more accurate:

* Architecture specific entries go below, followed by deprecated or obsolete
* system calls.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-03-07 09:27    [W:0.060 / U:11.256 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site