lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: isp1760: Use kasprintf
On Wed, Mar 07, 2018 at 08:20:54PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 7, 2018 at 8:08 PM, Himanshu Jha
> <himanshujha199640@gmail.com> wrote:
> > Use kasprintf instead of combination of kmalloc and sprintf and
> > therefore avoid unnecessary computation of string length.
>
> > devname = dev_name(isp->dev);
>
> Do you still need this temporary variable?

No.

> > - udc->irqname = kmalloc(strlen(devname) + 7, GFP_KERNEL);
> > + udc->irqname = kasprintf(GFP_KERNEL, "%s (udc)", devname);
>
> Perhaps
>
> devname -> dev_name(isp->dev)
>
> ?

Oh, yes!
Thanks for pointing that out.
I will send v2 with the update!

--
Thanks
Himanshu Jha

\
 
 \ /
  Last update: 2018-03-07 19:31    [W:0.030 / U:2.728 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site