lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/6] lib/scatterlist: Skip requesting zeroed allocations in sgl_alloc_order
From
Date

On 07/03/18 15:35, Andy Shevchenko wrote:
> On Wed, Mar 7, 2018 at 2:47 PM, Tvrtko Ursulin <tursulin@ursulin.net> wrote:
>
>> + sgl = kmalloc_array(nent, sizeof(struct scatterlist), (gfp & ~GFP_DMA));
>
> The parens now become redundant.

True thanks! I am also not sure that re-using the same gfp_t for
metadata is backing store is the right approach. At least I think
__GFP_HIGHMEM needs also to be cleared for kmalloc.

Regards,

Tvrtko

\
 
 \ /
  Last update: 2018-03-07 18:32    [W:0.048 / U:10.484 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site