Messages in this thread | | | Date | Wed, 7 Mar 2018 16:40:44 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 1/2] mfd: rk808: Change DEV_OFF to DEV_OFF_RST for rk818 shutdown |
| |
On Mon, 05 Mar 2018, Daniel Schultz wrote:
> After running "poweroff", the PMIC restarts the SoC instead of shutting > it down. > > It seems like the description for those two register bits is swapped. > After changing from DEV_OFF to DEV_OFF_RST, the system can poweroff > correctly. > > Signed-off-by: Daniel Schultz <d.schultz@phytec.de> > --- > drivers/mfd/rk808.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Please could you re-submit these 2 patches with the Rock Chips guys in Cc. It would be easier to review if we had some expert eyes-on and a Tested-by or 2.
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c > index 216fbf6..d138721 100644 > --- a/drivers/mfd/rk808.c > +++ b/drivers/mfd/rk808.c > @@ -418,7 +418,7 @@ static void rk818_device_shutdown(void) > > ret = regmap_update_bits(rk808->regmap, > RK818_DEVCTRL_REG, > - DEV_OFF, DEV_OFF); > + DEV_OFF_RST, DEV_OFF_RST); > if (ret) > dev_err(&rk808_i2c_client->dev, "power off error!\n"); > }
-- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |