lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC
On Wed, 07 Mar 2018, Lee Jones wrote:

> On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote:
>
> > From: Vincent Palatin <vpalatin@chromium.org>
> >
> > If we cannot communicate with the EC chip to detect the protocol version
> > and its features, it's very likely useless to continue. Else we will
> > commit all kind of uninformed mistakes (using the wrong protocol, the
> > wrong buffer size, mixing the EC with other chips).
> >
> > Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> > Acked-by: Benson Leung <bleung@chromium.org>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> > drivers/mfd/cros_ec.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
>
> Unless it is my mailer that is playing up, it looks as though you have
> sent this set un-threaded, which means that when others or myself
> start replying to them one-by-one, they will be sprawled throughout my
> inbox. It also seems as though there is no 0th (cover letter) patch,
> which means I am lacking potentially important information regarding
> the history of the set and what you are trying to achieve.
>
> Anyway, the patch has been applied this time (hopefully there aren't
> any inter-dependencies.

As discussed in 2/6, I'm going to un-apply this.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2018-03-07 16:18    [W:0.053 / U:4.416 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site