[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789
Hello Mark,

Thanks for the review.

On Mon, 5 Mar 2018 15:59:38 +0000
Mark Brown <> wrote:

> On Mon, Mar 05, 2018 at 04:57:15PM +0100, Alexandre Belloni wrote:
> > On 05/03/2018 at 15:49:10 +0000, Mark Brown wrote:
> > > Please don't mix C and C++ style comments in a single comment like this
> > > - it looks unintentional. Just use the same style for the whole thing.
> > > You also don't need to include all the boilerplate with the SPDX header.
> > I think Linus made it clear that he wants the SPDX header to be a
> > C++ comment, the documentation has:
> Sure, so make the entire thing a C++ comment then.

Ok, I saw other drivers with this mix C++/C comment code so I wrote it
like this but no problem using only C++ comment.

I will send a v3 with this modification only (except if I have other

Best regards,

Mylène Josserand, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering

 \ /
  Last update: 2018-03-07 15:35    [W:0.034 / U:3.088 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site