lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.15 69/78] RDMA/ocrdma: Fix permissions for OCRDMA_RESET_STATS
    Date
    From: Anton Vasilyev <vasilyev@ispras.ru>

    [ Upstream commit 744820869166c8c78be891240cf5f66e8a333694 ]

    Debugfs file reset_stats is created with S_IRUSR permissions,
    but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS,
    whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS.

    The patch fixes misstype with permissions.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
    Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
    index e528d7acb7f6..fb78b16ce671 100644
    --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
    +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
    @@ -834,7 +834,7 @@ void ocrdma_add_port_stats(struct ocrdma_dev *dev)

    dev->reset_stats.type = OCRDMA_RESET_STATS;
    dev->reset_stats.dev = dev;
    - if (!debugfs_create_file("reset_stats", S_IRUSR, dev->dir,
    + if (!debugfs_create_file("reset_stats", 0200, dev->dir,
    &dev->reset_stats, &ocrdma_dbg_ops))
    goto err;

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-08 07:51    [W:4.176 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site