lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services()
Date
-0800, Sai Praneeth Prakhya wrote:
> > @@ -329,6 +331,19 @@ static int __init efisubsys_init(void)
> > return 0;
> >
> > /*
> > + * Since we process only one efi_runtime_service() at a time, an
> > + * ordered workqueue (which creates only one execution context)
> > + * should suffice all our needs.
> > + */
> > + efi_rts_wq = alloc_ordered_workqueue("efi_rts_workqueue", 0);
> > + if (!efi_rts_wq) {
> > + pr_err("Failed to create efi_rts_workqueue, EFI runtime services
> "
> > + "disabled.\n");
> > + clear_bit(EFI_RUNTIME_SERVICES, &efi.flags);
> > + return 0;
> > + }
>
> I'm a little worried that something might sample this flag between it being set in
> an early_initcall (arm_enable_runtime_services), and cleared in a subsys_initcall
> here.
>
> However, nothing seems to do that so far, so maybe that's ok...
>

Thanks for raising this. I will take a look at initcalls.

> [...]
>
> > +/* efi_runtime_service() function identifiers */ enum {
> > + GET_TIME,
> > + SET_TIME,
> > + GET_WAKEUP_TIME,
> > + SET_WAKEUP_TIME,
> > + GET_VARIABLE,
> > + GET_NEXT_VARIABLE,
> > + SET_VARIABLE,
> > + SET_VARIABLE_NONBLOCKING,
> > + QUERY_VARIABLE_INFO,
> > + QUERY_VARIABLE_INFO_NONBLOCKING,
> > + GET_NEXT_HIGH_MONO_COUNT,
> > + RESET_SYSTEM,
> > + UPDATE_CAPSULE,
> > + QUERY_CAPSULE_CAPS,
> > +};
>
> Can we please give this enum a name....

Sure! Added in V3.

>
> [...]
>
> > +/*
> > + * efi_runtime_work: Details of EFI Runtime Service work
> > + * @func: EFI Runtime Service function identifier
> > + * @arg<1-5>: EFI Runtime Service function arguments
> > + * @status: Status of executing EFI Runtime Service
> > + */
> > +struct efi_runtime_work {
> > + u8 func;
>
> ... and use it here rather than an opaque u8? I realise that means placing the
> enum in <linux/efi.h>.
>

Actually, with Miguel comments, I am considering making this struct static and moving
it to runtime-wrappers.c, since "struct efi_runtime_work" isn't really being used anywhere
except runtime-wrappers.c. Please see in V3.

> > + void *arg1;
> > + void *arg2;
> > + void *arg3;
> > + void *arg4;
> > + void *arg5;
> > + efi_status_t status;
> > + struct work_struct work;
> > +};
>
> Thanks,
> Mark.

\
 
 \ /
  Last update: 2018-03-08 05:01    [W:0.104 / U:0.760 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site