Messages in this thread | | | From | Horia Geantă <> | Subject | Re: [PATCH v11 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 | Date | Tue, 6 Mar 2018 12:37:27 +0000 |
| |
On 3/5/2018 9:08 PM, Logan Gunthorpe wrote: > Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 > functions in non-64bit cases in favour of the new common > io-64-nonatomic-lo-hi header. > > To be consistent with CAAM engine HW spec: in case of 64-bit registers, > irrespective of device endianness, the lower address should be read from > / written to first, followed by the upper address. Indeed the I/O > accessors in CAAM driver currently don't follow the spec, however this > is a good opportunity to fix the code. > > Signed-off-by: Logan Gunthorpe <logang@deltatee.com> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Horia Geantă <horia.geanta@nxp.com> > Cc: Dan Douglass <dan.douglass@nxp.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Please get used to carrying Reviewed-bys from previous iterations when patches stay the same: https://lkml.kernel.org/r/VI1PR0402MB334282217BC0AE1F8DA8BFC3981C0@VI1PR0402MB3342.eurprd04.prod.outlook.com
Thanks, Horia
| |