lkml.org 
[lkml]   [2018]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 2/2] i2c: mux: pca954x: verify the device id of the pca984x chips
From
Date
On 2018-03-05 16:53, Wolfram Sang wrote:
>
>> @@ -97,59 +98,83 @@ static const struct chip_desc chips[] = {
>> .nchans = 2,
>> .enable = 0x4,
>> .muxtype = pca954x_ismux,
>> + .id = { .manufacturer_id = I2C_DEVICE_ID_NONE },
>
> Can't we just leave this empty and add a NULL pointer check below when
> testing for the device id?

Nope, it's not a pointer. I didn't think it should be, but maybe it
should? The drawback is that you have to create an extra variable
for each of the chips that do need an id, and I didn't fancy that...

Cheers,
Peter

\
 
 \ /
  Last update: 2018-03-05 16:57    [W:0.218 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site