Messages in this thread | | | Subject | Re: [PATCH v6 13/20] firmware: arm_scmi: refactor in preparation to support per-protocol channels | From | Sudeep Holla <> | Date | Mon, 5 Mar 2018 14:43:52 +0000 |
| |
On 05/03/18 14:35, Jonathan Cameron wrote: > On Fri, 23 Feb 2018 16:23:43 +0000 > Sudeep Holla <sudeep.holla@arm.com> wrote: > >> In order to support per-protocol channels if available, we need to >> factor out all the mailbox channel information(Tx/Rx payload and >> channel handle) out of the main SCMI instance information structure. >> >> This patch refactors the existing channel information into a separate >> chan_info structure. >> >> Cc: Arnd Bergmann <arnd@arndb.de> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > A little odd to present a series to mainline that does a fairly important > refactor mid way through. Why not push this down to the start and always support > the separate chan_info structure? >
Since the development started long back and this was added later, I preferred to keep functionality working and didn't want to push change down in the stack.
-- Regards, Sudeep
| |