lkml.org 
[lkml]   [2018]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()
    On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote:
    > Replace printk having a log level with the appropriate
    > net_*macro_ratelimited.
    > It's better to use actual device name as a prefix in error messages.
    > Indentation is also changed, to fix the checkpatch issue if line is not
    > exceding 80 characters.
    >
    > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
    > ---
    > .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 22 +++++++++++-----------
    > 1 file changed, 11 insertions(+), 11 deletions(-)
    >
    > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
    > index e6648f7..200fe5f 100644
    > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
    > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
    > @@ -73,7 +73,7 @@ static void *ieee80211_ccmp_init(int key_idx)
    >
    > priv->tfm = (void *)crypto_alloc_cipher("aes", 0, CRYPTO_ALG_ASYNC);
    > if (IS_ERR(priv->tfm)) {
    > - printk(KERN_DEBUG "ieee80211_crypt_ccmp: could not allocate crypto API aes\n");
    > + net_dbg_ratelimited("ieee80211_crypt_ccmp: could not allocate crypto API aes\n");


    This should probably just be deleted.

    > priv->tfm = NULL;
    > goto fail;
    > }
    > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
    > keyidx = pos[3];
    > if (!(keyidx & (1 << 5))) {
    > if (net_ratelimit()) {
    > - printk(KERN_DEBUG "CCMP: received packet without ExtIV flag from %pM\n",
    > - hdr->addr2);
    > + net_dbg_ratelimited("CCMP: received packet without ExtIV flag from %pM\n",
    > + hdr->addr2);
    > }

    The "if (net_ratelimit()) " already means the message is ratelimited so
    it's net_dbg() ok? I think so, but I've never looked at this before.

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2018-03-05 11:19    [W:7.724 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site