lkml.org 
[lkml]   [2018]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next 1/5] net: mvpp2: use the same buffer pool for all ports
Date
> Hello,
>
> On Fri, 2 Mar 2018 16:40:40 +0100, Antoine Tenart wrote:
> > +static struct {
> > + int pkt_size;
> > + int buf_num;
> > +} mvpp2_pools[MVPP2_BM_POOLS_NUM];
>
> Any reason for not doing:
>
> } mvpp2_pools[MVPP2_BM_POOLS_NUM] = {
> [MVPP2_BM_SHORT] = {
> .pkt_size = MVPP2_BM_SHORT_PKT_SIZE,
> .buf_num = MVPP2_BM_SHORT_BUF_NUM
> },
> [MVPP2_BM_LONG] = {
> .pkt_size = MVPP2_BM_LONG_PKT_SIZE,
> .buf_num = MVPP2_BM_LONG_BUF_NUM,
> },
> };
>
> And get rid of:
>
> > +static void mvpp2_setup_bm_pool(void) {
> > + /* Short pool */
> > + mvpp2_pools[MVPP2_BM_SHORT].buf_num =
> MVPP2_BM_SHORT_BUF_NUM;
> > + mvpp2_pools[MVPP2_BM_SHORT].pkt_size =
> MVPP2_BM_SHORT_PKT_SIZE;
> > +
> > + /* Long pool */
> > + mvpp2_pools[MVPP2_BM_LONG].buf_num =
> MVPP2_BM_LONG_BUF_NUM;
> > + mvpp2_pools[MVPP2_BM_LONG].pkt_size =
> MVPP2_BM_LONG_PKT_SIZE; }
>
> ?
>

No, we can change it.

Stefan.

\
 
 \ /
  Last update: 2018-03-04 08:00    [W:0.064 / U:25.120 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site